fix(javascript): truncate meta string dispose list on write reset - #4015
Merged
Merged
Conversation
MetaStringWriter.reset() restored each entry's dynamicWriteStringId but never truncated the list, so every root serialization of a named type re-pushed the same MetaStringBytes owners. The list grew by every past root operation and each reset walked the whole history.
chaokunyang
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the error
MetaStringWriter.reset()restored each entry'sdynamicWriteStringIdbut never truncateddisposeMetaStringBytes. Since meta string owners re-push themselves on every root serialization of a named type, the list grew by every past root operation (an unbounded leak in long-running processes) and each reset walked the whole history.What this PR fixes
reset()now truncates the list after restoring the ids, so it only ever holds the current root's entries. A regression test asserts the list stays at its baseline size across 100 root serializations.